Added ability to have multiple chats #194

eduardsmetanin · 2020-10-12T00:29:33Z

@mattmezza Please let me know if you have any questions or want to discuss. I updated the the chat and the demo, but not your doc. I can do it if necessary. The old demo works with the new chat, so the changes are backward compatible.

eduardsmetanin · 2020-10-12T01:03:06Z

@mattmezza Hi Matteo! It looks like mine and several other pull requests failing checks with error "Error: Resource not accessible by integration". It seems to be only happening right after message "Adding message: Thanks for sending out your first PR! to pull request". Could you take a look? https://github.com/mattmezza/vue-beautiful-chat/pull/194/checks?check_run_id=1239683641 The issue is discussed here actions/first-interaction#10 Could you remove this action?

mattmezza

Hi @eduardsmetanin and thanks for this great contribution! This brings a cool feature and I'm excited to merge it asap. I only have some minor comments that I would like to tackle before merging.
Also, I have been merging some new addition and it would be great to rebase on master 👍

@a-kriya had an idea to further improve this library be pushing some of the props that are now propagated to deeply nested components back into the store. This would simplify the setup even more (see #178).

Cheers,
Matt.

src/ChatList.vue

src/ChatWindow.vue

src/Launcher.vue

eduardsmetanin · 2020-10-20T18:05:36Z

@mattmezza I'm done with my fixes. Please take a look again. As for @a-kriya 's idea, why don't you merge it? It would be easier for contributors to see it and do the same. Right now I don't feel like converting my code to this style within this already large pull request.

a-kriya · 2020-10-21T00:23:15Z

@eduardsmetanin It's been merged. Since there are now conflicts with master, you'll have to rebase and resolve them. And using the store to access the necessary props will reduce the size of the diff.

… param.

…with ''.

eduardsmetanin · 2020-10-22T17:52:53Z

@mattmezza @a-kriya This pull request is rebased and ready to be merged. I tried to use store to pass props, but I ran into 2 issues and rolled back store.state my changes:

A prop is undefined when accessed from a method called from data() and this prop is populated via ...mapState(). Perhaps initial value can be set like this:
const store = { state: Vue.observable({ editMessage: null }),, but I ran into a case when I needed my data (initialized in data()) to depend on a prop, which didn't work because of undefined value in the prop. As a workaround this prop can be accessed via store.state['my_prop_name']. This caused me a lot of time and frustration. Vue props work well in this case and I think we need a state management system that works just like standard props.
We currently update entire state map on every prop change:
handler(props) { // TODO: optimize for (const prop in props) { store.setState(prop, props[prop]) } }. The TODO says it needs to be optimized. I don't know how it can be optimized.

Does Vue 3 provide an easier way to manage state? Perhaps we should wait for Vue 3 conversion and then change how we manage state?

a-kriya · 2020-10-22T21:26:30Z

demo/src/App.vue

+      const chat = this.chatHistory[this.currentChatID];
+      if (chat === undefined) {
+        return [];
+      }
+      return chat["messages"];
+    },
+    participants() {
+      const chat = this.chatHistory[this.currentChatID];
+      if (chat === undefined) {
+        return [];
+      }
+      return chat["participants"];


Parts of this diff has semi-colons and uses double-quotes instead of single. Can you please run npm run lint and update this PR? It should fix most style issues automatically.
Why access object props using subscripts rather than a period?

a-kriya · 2020-10-22T21:34:34Z

demo/src/TestArea.vue

+    multipleChatsEnabled: {
+      type: Boolean,
+      required: true


Why is this a prop? Is there any difference when this is off? I would expect a single instance of the component to work just as it has, and multiple instances to also work out-of-the-box. I can't see why it needs to be configured.

In multi-room mode, when chat window is opened, I show list of chat rooms (as opposite to chat right away). Also, in the header for chat window I show go-back-to-chat-list button. I use multipleChatsEnabled prop to determine if those 2 things need to be done. I don't see any other good way to do it. The main reason for that is the demo app is controlling the chat content and there is only one property (messageList) with chat content it passes launcher. So, the demo app puts correct chat content when chat room changes. I considered to use chatList prop instead of multipleChatsEnabled (if it's empty or undefined than assume single chat mode), but it's possible to have 0 chat rooms in multi-chat mode.

…longer available.

…t is no longer available.

silasrm · 2020-11-27T17:41:21Z

Hi guys,

Any news about this PR? I'm finding this feature.
@eduardsmetanin if I clone your repo, this is 100% ok?
Doc in your repo is outdated!

eduardsmetanin · 2020-11-28T15:42:37Z

Hi guys,

Any news about this PR? I'm finding this feature.
@eduardsmetanin if I clone your repo, this is 100% ok?
Doc in your repo is outdated!

@silasrm You can use my clone if you want. I do NOT promise to maintain it though. I haven't updated any docs yet. It would be good to see a will to merge my changes from maintainer @mattmezza before I spend any more time on it.

silasrm · 2020-11-28T18:23:45Z

Hi guys,
Any news about this PR? I'm finding this feature.
@eduardsmetanin if I clone your repo, this is 100% ok?
Doc in your repo is outdated!

@silasrm You can use my clone if you want. I do NOT promise to maintain it though. I haven't updated any docs yet. It would be good to see a will to merge my changes from maintainer @mattmezza before I spend any more time on it.

I'm using after clone and build. Now, I'm trying to integrate to https://github.com/musonza/chat :D

silasrm · 2020-11-30T12:25:12Z

@eduardsmetanin I add support to toolbox on emoji and file message types.
beefreelancer#1

Add support to toolbox on Emoji and File message type.

…de with lint

Pulling fixes.

miloandco · 2021-03-12T13:59:07Z

@mattmezza Could you please merge this pull request?

miloandco · 2021-03-15T12:00:23Z

@eduardsmetanin Could you maybe solve the conflict so that your pull request can be merged in? :)

eduardsmetanin · 2021-03-16T01:33:12Z

@a-kriya Will you merge this pull request if I resolve conflicts? People ask for my changes once in a while, so I think it would be beneficial for the project. I can walk you through my changes via a conference call if you wish.

Attn: @miloandco @oldner

@eduardsmetanin Could you maybe solve the conflict so that your pull request can be merged in? :)

stale · 2021-05-15T10:37:16Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-07-15T10:20:22Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-11-06T12:51:14Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mattmezza requested changes Oct 18, 2020

View reviewed changes

src/ChatList.vue Outdated Show resolved Hide resolved

src/ChatWindow.vue Show resolved Hide resolved

src/ChatWindow.vue Outdated Show resolved Hide resolved

src/Launcher.vue Outdated Show resolved Hide resolved

This was referenced Oct 18, 2020

Compare author against id instead of 'me' #116

Open

Get author name in the backend #193

Closed

Local author id (me) as property #109

Open

eduardsmetanin force-pushed the master branch from f24f365 to dcc82f8 Compare October 19, 2020 22:26

eduardsmetanin force-pushed the master branch from b5eca1c to cd117f2 Compare October 21, 2020 14:18

eduardsmetanin added 17 commits October 22, 2020 11:18

Added multiple chats functionality.

c394c26

Changed chatList prop to not required.

f2a49eb

Renamed a prop and reordered a few props.

d28f795

Added multiple chats to demo.

dbb7cb1

Fixed bugs due to v-on='' by re-emitting events on every component.

c45b282

Fixed text alignment in ChatList and UserList.

6e5aa75

Added ability to specify user ID in chat json instead of 'me'.

8825474

Set header image size to be a constant independent of actual image size.

10bd969

Added 'box-sizing: border-box' to title image. Added chatListImageUrl…

6c7bf40

… param.

Removed margin-right for 'go back' button.

ee8aa9c

Updated chat list layout.

c08382c

More changes to chat list layout.

9b93095

Added code-workspace files to gitignore.

c7ed93e

Set border-collapse: collapse.

c573bdb

Added cursor: pointer to chat list row. Replaced calls like () => '' …

38cd562

…with ''.

Fixed remaining rebase issues.

821ec66

Renamed ChatWindow.vue's var 'state' to 'windowState'.

fbe2cac

eduardsmetanin force-pushed the master branch from a0d2124 to fbe2cac Compare October 22, 2020 17:35

a-kriya reviewed Oct 22, 2020

View reviewed changes

eduardsmetanin added 5 commits November 5, 2020 11:37

Renamed param to user.

931640f

Handled case when currently open chat is no longer available.

fb59708

Fixed demo app to show developers how to handle chat room that is no …

16aa042

…longer available.

Fixed (again) demo app to show developers how to handle chat room tha…

968f543

…t is no longer available.

Added props to show header and message icon clickable.

00454fe

Add support to toolbox on Emoji and File message type.

c92b3c1

eduardsmetanin and others added 7 commits December 1, 2020 08:02

Merge pull request #1 from silasrm/master

a6da716

Add support to toolbox on Emoji and File message type.

Fix wrong default value for confirmationDeletionMessage param. Fix co…

c7e3acc

…de with lint

Change button style on sc-message--emoji > sc-message--toolbox

ffe8608

Merge pull request #2 from silasrm/master

28869d5

Pulling fixes.

yarn lint.

9eacbc4

Fixed aspect ratio for non-square images in chat list.

92bc47e

No longer showing keyboard on mobile devices when user opens a chat.

1e89a12

stale bot added the stale label May 15, 2021

a-kriya removed the stale label May 16, 2021

stale bot added the stale label Jul 15, 2021

a-kriya removed the stale label Jul 15, 2021

stale bot added the stale label Nov 6, 2021

a-kriya added the pinned label Nov 6, 2021

stale bot removed the stale label Nov 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ability to have multiple chats #194

Added ability to have multiple chats #194

eduardsmetanin commented Oct 12, 2020

eduardsmetanin commented Oct 12, 2020 •

edited

mattmezza left a comment

eduardsmetanin commented Oct 20, 2020

a-kriya commented Oct 21, 2020

eduardsmetanin commented Oct 22, 2020

a-kriya Oct 22, 2020 •

edited

a-kriya Oct 22, 2020 •

edited

eduardsmetanin Oct 22, 2020

silasrm commented Nov 27, 2020 •

edited

eduardsmetanin commented Nov 28, 2020

silasrm commented Nov 28, 2020

silasrm commented Nov 30, 2020

miloandco commented Mar 12, 2021

miloandco commented Mar 15, 2021

eduardsmetanin commented Mar 16, 2021

stale bot commented May 15, 2021

stale bot commented Jul 15, 2021

stale bot commented Nov 6, 2021

Added ability to have multiple chats #194

Are you sure you want to change the base?

Added ability to have multiple chats #194

Conversation

eduardsmetanin commented Oct 12, 2020

eduardsmetanin commented Oct 12, 2020 • edited

mattmezza left a comment

Choose a reason for hiding this comment

eduardsmetanin commented Oct 20, 2020

a-kriya commented Oct 21, 2020

eduardsmetanin commented Oct 22, 2020

a-kriya Oct 22, 2020 • edited

Choose a reason for hiding this comment

a-kriya Oct 22, 2020 • edited

Choose a reason for hiding this comment

eduardsmetanin Oct 22, 2020

Choose a reason for hiding this comment

silasrm commented Nov 27, 2020 • edited

eduardsmetanin commented Nov 28, 2020

silasrm commented Nov 28, 2020

silasrm commented Nov 30, 2020

miloandco commented Mar 12, 2021

miloandco commented Mar 15, 2021

eduardsmetanin commented Mar 16, 2021

stale bot commented May 15, 2021

stale bot commented Jul 15, 2021

stale bot commented Nov 6, 2021

eduardsmetanin commented Oct 12, 2020 •

edited

a-kriya Oct 22, 2020 •

edited

a-kriya Oct 22, 2020 •

edited

silasrm commented Nov 27, 2020 •

edited