Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local author id (me) as property #109

Open
0xfrej opened this issue Jul 15, 2019 · 5 comments
Open

Local author id (me) as property #109

0xfrej opened this issue Jul 15, 2019 · 5 comments
Labels
help wanted Extra attention is needed pinned

Comments

@0xfrej
Copy link

0xfrej commented Jul 15, 2019

I'd like to have option for changing author me as it would erase needment for writing middleware that would be replacing it for correct id (possibly with huge performance impact upon message batch loading from server).

@MaeseppTarvo
Copy link

MaeseppTarvo commented Aug 29, 2019

Yep, should be awesome if you can declare "me" as a prop so we can use ID instead of "me". Would be silly to write some function that detects who is me at what time when it would be easy to compare it against prop 😊

Also there should be ability to declare keys for name, imageURL etc.. It is also doable, just check if there is prop, if not then use your own keys but if there is you can use dynamic keys.

I added the ability to have "me" as a prop on my local project. If there is no activity soon I can create the fork if I have time.  🍻

@mattmezza
Copy link
Owner

Hello and thanks for stopping by.

I definitely agree. me doesn't make much sense to be honest.

@MaeseppTarvo's proposal makes sense, if you could make a PR I would merge it and make the final adjustments if needed.

Cheers.

@mattmezza mattmezza added the help wanted Extra attention is needed label Sep 5, 2019
@MaeseppTarvo
Copy link

@mattmezza I created PR #116

@stale
Copy link

stale bot commented Jun 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 13, 2020
@mattmezza mattmezza added pinned and removed wontfix This will not be worked on labels Jun 14, 2020
@mattmezza
Copy link
Owner

being worked on in #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

3 participants