Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare author against id instead of 'me' #116

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MaeseppTarvo
Copy link

@MaeseppTarvo MaeseppTarvo commented Sep 6, 2019

If backward-compability is needed then we gotta do some checks and make authorID not required. Right now there is new prop needed, authorId which is current user id.

@mattmezza
Copy link
Owner

I think we should keep backward compatibility and release this feature. At the moment I don't have that many active collaborators to be able to start working on a version 3.

I will definitely organize the issues and assess what needs to be included and when would be a right moment to start working on v3.

Thanks for this PR and let me know if you can take care of the backward compatibility.

Cheers.

@arabakevin
Copy link
Contributor

Hi,
Do you have an estimation or an delay for this feature because i would like use this feature too.
Thanks
best

@j-tegen
Copy link

j-tegen commented Jan 3, 2020

An easy fix for backwards compatibility would be to add a default value?

authorId: {
  type: String,
  required: false,
  default: 'me'
}

This is a great feature and would help us quite a bit.

@stale
Copy link

stale bot commented Jun 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 13, 2020
@mattmezza mattmezza added pinned and removed wontfix This will not be worked on labels Jun 14, 2020
@mattmezza
Copy link
Owner

Will be tackled in #194 thanks for the idea :) 👍

@mattmezza mattmezza closed this Oct 18, 2020
@a-kriya
Copy link
Collaborator

a-kriya commented May 18, 2021

@mattmezza I think we should include this as a separate thing as it'll be much quicker than tackling that huge PR (and it will make #194 simpler, too, I think). The authorId will be put in the store so I'll update this PR.

@a-kriya a-kriya reopened this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants