Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few typos #13404

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix a few typos #13404

merged 1 commit into from
Jun 4, 2024

Conversation

rparrett
Copy link
Contributor

Objective

Fix a few typos I spotted while looking over #13347

Solution

Fix em

@bushrat011899 bushrat011899 added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy labels May 17, 2024
@alice-i-cecile alice-i-cecile added the S-Blocked This cannot move forward until something else changes label May 17, 2024
@alice-i-cecile
Copy link
Member

Blocked until #13414 is merged to avoid making a mess.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 17, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone May 17, 2024
@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Blocked This cannot move forward until something else changes labels May 23, 2024
@alice-i-cecile alice-i-cecile removed the S-Blocked This cannot move forward until something else changes label Jun 3, 2024
@alice-i-cecile
Copy link
Member

No longer blocked; just need to wait for the linked PR to get merged and then I'll update this to main again :)

@alice-i-cecile alice-i-cecile mentioned this pull request Jun 3, 2024
Merged
@alice-i-cecile alice-i-cecile added the S-Blocked This cannot move forward until something else changes label Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
@alice-i-cecile @bushrat011899
@Themayu @BD103
Add on_unimplemented Diagnostics to Most Public Traits (#13347) (#1…
ec7b349 
…3662)

# Objective

- #13414 did not have the intended effect.
- #13404 is still blocked

## Solution

- Re-adds #13347.

Co-authored-by: Zachary Harrold <zac@harrold.com.au>
Co-authored-by: Jamie Ridding <Themayu@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
@alice-i-cecile alice-i-cecile removed the S-Blocked This cannot move forward until something else changes label Jun 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 4, 2024
@alice-i-cecile
Copy link
Member

The most complex two-line typo fix PR I've ever merged 😓

Merged via the queue into bevyengine:main with commit ab2add6 Jun 4, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@jgayfer jgayfer jgayfer approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rparrett @alice-i-cecile @nicoburns @bushrat011899 @jgayfer @JMS55