Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document need to update Aabb in Mesh::(with_)insert_attribute #13349

Merged
merged 4 commits into from
Jun 4, 2024
Merged

document need to update Aabb in Mesh::(with_)insert_attribute #13349

merged 4 commits into from
Jun 4, 2024

Conversation

ua-kxie
Copy link
Contributor

@ua-kxie ua-kxie commented May 13, 2024 •
edited

Objective

solves #12475 for functions Mesh::insert_attribute and Mesh::with_inserted_attribute.

Solution

added references to Aabb and suggest solutions in doc strings

Testing

ran cargo docs, links work.

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@pablo-lua pablo-lua added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen labels May 13, 2024
@ua-kxie ua-kxie marked this pull request as draft May 14, 2024 06:12
@ua-kxie ua-kxie closed this May 14, 2024
@ua-kxie ua-kxie reopened this May 14, 2024
@ua-kxie ua-kxie marked this pull request as ready for review May 14, 2024 08:31
BD103
BD103 approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for letting this sit for so long.

I have one small nit grammar-wise, but that's all. I'm going to mark this as S-Needs-Review so it gets a bit more attention.

P.S. you can add "Closes #12475" or "Solves #12475" to the original PR description and Github will automatically close the issue when this gets merged.

crates/bevy_render/src/mesh/mesh/mod.rs Outdated Show resolved Hide resolved
@BD103 BD103 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jun 2, 2024
@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 2, 2024
@ua-kxie @BD103
Update crates/bevy_render/src/mesh/mesh/mod.rs
4583e15 
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 1b6bc2c Jun 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ua-kxie @IceSentry @BD103 @alice-i-cecile @pablo-lua