Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/scabs1 #2209

Merged
merged 27 commits into from
Jun 7, 2024
Merged

feat: add blas/base/scabs1 #2209

merged 27 commits into from
Jun 7, 2024

Conversation

aman-095
Copy link
Contributor

Description

This RFC proposes to add a routine to compute the sum of the absolute value of the real and imaginary part of a single-precision complex floating-point number as defined in BLAS scalar operations. Specifically adding @stdlib/blas/base/scabs1 is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 27, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label May 23, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 6, 2024
@kgryte kgryte mentioned this pull request Jun 6, 2024
1 task
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 6, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-095 This PR is close. I had to do a decent amount of clean-up, including addressing copy-paste errors. What remains is updating the benchmark files and adding the C API documentation to the README.

@kgryte
Copy link
Member

kgryte commented Jun 6, 2024

@aman-095 Thanks for making the changes. Anything else needing to be done? If not, you can go ahead and port the changes over to dcabs1 so we can get that one over the finish line, as well.

@aman-095
Copy link
Contributor Author

aman-095 commented Jun 6, 2024

Thanks, Athan, for reviewing. This seems fine to me. I'm also replicating this in dcabs1 and will push the changes soon.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jun 7, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had to make a few more changes. Note that the dependencies for each configuration in a manifest.json file should include only those packages which are necessary for that build. Some of them had extraneous deps or were missing others. Will merge once CI passes.

@kgryte kgryte merged commit 70864fa into stdlib-js:develop Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants