-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blas/base/scabs1
#2209
Conversation
lib/node_modules/@stdlib/blas/base/scabs1/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/base/scabs1/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
…/aman-095/2209
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aman-095 This PR is close. I had to do a decent amount of clean-up, including addressing copy-paste errors. What remains is updating the benchmark files and adding the C API documentation to the README.
@aman-095 Thanks for making the changes. Anything else needing to be done? If not, you can go ahead and port the changes over to |
Thanks, Athan, for reviewing. This seems fine to me. I'm also replicating this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Had to make a few more changes. Note that the dependencies for each configuration in a manifest.json file should include only those packages which are necessary for that build. Some of them had extraneous deps or were missing others. Will merge once CI passes.
Description
This RFC proposes to add a routine to compute the sum of the absolute value of the real and imaginary part of a single-precision complex floating-point number as defined in BLAS scalar operations. Specifically adding
@stdlib/blas/base/scabs1
is proposed.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers