Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/dcabs1 #2204

Merged
merged 18 commits into from
Jun 7, 2024
Merged

feat: add blas/base/dcabs1 #2204

merged 18 commits into from
Jun 7, 2024

Conversation

aman-095
Copy link
Contributor

@aman-095 aman-095 commented Apr 25, 2024

Description

This PR adds a routine to compute the sum of the absolute value of the real and imaginary part of a double-precision complex floating-point number as defined in BLAS scalar operations. Specifically, this PR adds @stdlib/blas/base/dcabs1.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 25, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label May 23, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 6, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-095 Labeling this PR as needing changes, as the updates from #2209 should be similarly applied here.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 6, 2024
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jun 7, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I went ahead and addressed the rest of the changes.

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit a4748fb into stdlib-js:develop Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants