Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change custom_skip_targets meaning for constant_prop_pass #3491

Closed
wants to merge 1 commit into from

Commits on May 10, 2024

  1. Change custom_skip_targets meaning for constant_prop_pass (pytorch#3491)

    Summary:
    
    Some users of `constant_prop_pass` want to fold across calls to
    `full`, because representing a tensor as a program constant is a requirement
    for some backends.
    This came up when writing some tests using `torch.ones` as a weight tensor,
    which is represented as `aten.full` in Edge Dialect.
    
    When the user specifies a custom skip set, do *not* add the default `aten.full`
    function, in case the user doesn't want it.
    
    Reviewed By: angelayi
    
    Differential Revision: D56894215
    dulinriley authored and facebook-github-bot committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fe6193e View commit details
    Browse the repository at this point in the history