Change custom_skip_targets meaning for constant_prop_pass #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3491
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe6193e with merge base c83af25 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56894215 |
|
This pull request was exported from Phabricator. Differential Revision: D56894215 |
dulinriley
force-pushed
the
export-D56894215
branch
from
cd65665
to
dde63a1
Compare
dulinriley
added a commit
to dulinriley/executorch-1
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: pytorch#3491 Some users of `constant_prop_pass` want to fold across calls to `full`, because representing a tensor as a program constant is a requirement for some backends. This came up when writing some tests using `torch.ones` as a weight tensor, which is represented as `aten.full` in Edge Dialect. When the user specifies a custom skip set, do *not* add the default `aten.full` function, in case the user doesn't want it. Differential Revision: D56894215
dulinriley
force-pushed
the
export-D56894215
branch
from
dde63a1
to
e4be6da
Compare
dulinriley
added a commit
to dulinriley/executorch-1
that referenced
this pull request
May 9, 2024
Summary: Some users of `constant_prop_pass` want to fold across calls to `full`, because representing a tensor as a program constant is a requirement for some backends. This came up when writing some tests using `torch.ones` as a weight tensor, which is represented as `aten.full` in Edge Dialect. When the user specifies a custom skip set, do *not* add the default `aten.full` function, in case the user doesn't want it. Differential Revision: D56894215
|
This pull request was exported from Phabricator. Differential Revision: D56894215 |
angelayi
approved these changes
May 10, 2024
dulinriley
force-pushed
the
export-D56894215
branch
from
e4be6da
to
a5829ab
Compare
dulinriley
added a commit
to dulinriley/executorch-1
that referenced
this pull request
May 10, 2024
Summary: Some users of `constant_prop_pass` want to fold across calls to `full`, because representing a tensor as a program constant is a requirement for some backends. This came up when writing some tests using `torch.ones` as a weight tensor, which is represented as `aten.full` in Edge Dialect. When the user specifies a custom skip set, do *not* add the default `aten.full` function, in case the user doesn't want it. Reviewed By: angelayi Differential Revision: D56894215
|
This pull request was exported from Phabricator. Differential Revision: D56894215 |
Summary: Some users of `constant_prop_pass` want to fold across calls to `full`, because representing a tensor as a program constant is a requirement for some backends. This came up when writing some tests using `torch.ones` as a weight tensor, which is represented as `aten.full` in Edge Dialect. When the user specifies a custom skip set, do *not* add the default `aten.full` function, in case the user doesn't want it. Reviewed By: angelayi Differential Revision: D56894215
dulinriley
force-pushed
the
export-D56894215
branch
from
a5829ab
to
fe6193e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56894215 |
|
This pull request has been merged in b93b7ae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some users of
constant_prop_passwant to fold across calls tofull, because representing a tensor as a program constant is a requirementfor some backends.
This came up when writing some tests using
torch.onesas a weight tensor,which is represented as
aten.fullin Edge Dialect.When the user specifies a custom skip set, do not add the default
aten.fullfunction, in case the user doesn't want it.
Differential Revision: D56894215