Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: implement global goroutine pool #53299

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 15, 2024

What problem does this PR solve?

Issue Number: close #52887

Problem Summary:

What changed and how does it work?

Goroutines with short lifetime often release its stack soon after several stack grows, this made newstack a performance issue. This PR create a global goroutine pool, reuse the stack, which shows a great improvement, high QPS with lower CPU utilization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Sysbench read only(with --point-selects=0)

thread nightly this pr diff
100 105052 qps 110537 qps +5.2%
200 100057 qps 121466 qps +21.4%

TPC-C

nightly this pr diff
106864 tpmC 115495 tpmC +8.1%

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Optimize performance by a global goroutine pool. 

@ti-chi-bot ti-chi-bot bot added release-note sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2024
Copy link

ti-chi-bot bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid, ywqzzy for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented May 15, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/ok-to-test

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 74.6489%. Comparing base (2d552c0) to head (d20f093).
Report is 29 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53299        +/-   ##
================================================
+ Coverage   72.4523%   74.6489%   +2.1965%     
================================================
  Files          1493       1500         +7     
  Lines        429365     436131      +6766     
================================================
+ Hits         311085     325567     +14482     
+ Misses        99001      90377      -8624     
- Partials      19279      20187       +908     
Flag Coverage Δ
integration 49.1002% <80.0000%> (?)
unit 71.3263% <48.3333%> (-0.0241%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.4451% <ø> (+8.0216%) ⬆️

Signed-off-by: you06 <you1474600@gmail.com>

global gp demo

Signed-off-by: you06 <you1474600@gmail.com>

fmt code

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

add threshold for shared pool

Signed-off-by: you06 <you1474600@gmail.com>

comment code

Signed-off-by: you06 <you1474600@gmail.com>

close the global pool when kvstore is closed only

Signed-off-by: you06 <you1474600@gmail.com>

fmt code

Signed-off-by: you06 <you1474600@gmail.com>
you06 added 2 commits May 17, 2024 13:11
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@XuHuaiyu
Copy link
Contributor

Why not use other existing open-source implementations, such as https://github.com/panjf2000/ants?

@you06
Copy link
Contributor Author

you06 commented May 21, 2024

Why not use other existing open-source implementations, such as https://github.com/panjf2000/ants?

Thanks for the suggestion, I'll compare the performance between ants, gp and other implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use goroutine pool to copr.(*copIteratorWorker).run
3 participants