-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: implement global goroutine pool #53299
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53299 +/- ##
================================================
+ Coverage 72.4523% 74.6489% +2.1965%
================================================
Files 1493 1500 +7
Lines 429365 436131 +6766
================================================
+ Hits 311085 325567 +14482
+ Misses 99001 90377 -8624
- Partials 19279 20187 +908
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: you06 <you1474600@gmail.com> global gp demo Signed-off-by: you06 <you1474600@gmail.com> fmt code Signed-off-by: you06 <you1474600@gmail.com> add comment Signed-off-by: you06 <you1474600@gmail.com> add comment Signed-off-by: you06 <you1474600@gmail.com> add threshold for shared pool Signed-off-by: you06 <you1474600@gmail.com> comment code Signed-off-by: you06 <you1474600@gmail.com> close the global pool when kvstore is closed only Signed-off-by: you06 <you1474600@gmail.com> fmt code Signed-off-by: you06 <you1474600@gmail.com>
Why not use other existing open-source implementations, such as https://github.com/panjf2000/ants? |
Thanks for the suggestion, I'll compare the performance between ants, gp and other implementations. |
What problem does this PR solve?
Issue Number: close #52887
Problem Summary:
What changed and how does it work?
Goroutines with short lifetime often release its stack soon after several stack grows, this made
newstack
a performance issue. This PR create a global goroutine pool, reuse the stack, which shows a great improvement, high QPS with lower CPU utilization.Check List
Tests
Sysbench read only(with
--point-selects=0
)TPC-C
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.