Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: implement global goroutine pool (#53299) #53346

Closed
wants to merge 2 commits into from

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 17, 2024

cherry pick #53299 to release-8.1 branch

What problem does this PR solve?

Issue Number: close #52887

Problem Summary:

What changed and how does it work?

Goroutines with short lifetime often release its stack soon after several stack grows, this made newstack a performance issue. This PR create a global goroutine pool, reuse the stack, which shows a great improvement, high QPS with lower CPU utilization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Sysbench read only(with --point-selects=0)

thread nightly this pr diff
100 105052 qps 110537 qps +5.2%
200 100057 qps 121466 qps +21.4%

TPC-C

nightly this pr diff
106864 tpmC 115495 tpmC +8.1%

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Optimize performance by a global goroutine pool. 

Signed-off-by: you06 <you1474600@gmail.com>

global gp demo

Signed-off-by: you06 <you1474600@gmail.com>

fmt code

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

add comment

Signed-off-by: you06 <you1474600@gmail.com>

add threshold for shared pool

Signed-off-by: you06 <you1474600@gmail.com>

comment code

Signed-off-by: you06 <you1474600@gmail.com>

close the global pool when kvstore is closed only

Signed-off-by: you06 <you1474600@gmail.com>

fmt code

Signed-off-by: you06 <you1474600@gmail.com>
Copy link

ti-chi-bot bot commented May 17, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2024
Copy link

tiprow bot commented May 17, 2024

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: you06 <you1474600@gmail.com>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-8.1@d4fe60e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53346   +/-   ##
================================================
  Coverage               ?   71.1591%           
================================================
  Files                  ?       1466           
  Lines                  ?     421464           
  Branches               ?          0           
================================================
  Hits                   ?     299910           
  Misses                 ?     101087           
  Partials               ?      20467           
Flag Coverage Δ
unit 71.1591% <48.3333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9637% <0.0000%> (?)

@you06
Copy link
Contributor Author

you06 commented May 22, 2024

Close thie PR because we won't backport it to 8.1, supress the regression by #53429.

@you06 you06 closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant