Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use goroutine pool to copr.(*copIteratorWorker).run #52887

Open
hawkingrei opened this issue Apr 25, 2024 · 1 comment · May be fixed by #53299
Open

use goroutine pool to copr.(*copIteratorWorker).run #52887

hawkingrei opened this issue Apr 25, 2024 · 1 comment · May be fixed by #53299
Labels
type/enhancement

Comments

@hawkingrei
Copy link
Member

Enhancement

github.com/pingcap/tidb/pkg/store/copr.(*copIteratorWorker).run will always do the runtime.newstack and it will take many time on it. so we can use goroutine pool to resolve it.

https://flamegraph.com/share/7adb104e-02f1-11ef-a542-36adf59c1176

image
@you06
Copy link
Contributor

you06 commented May 15, 2024 •
edited

Nice catch! This issue impacts the latency and cpu usage more when the coprocessor tasks are small.

I've test a read case with tiny coprocessor queries.

without goroutine pool with goroutine pool diff
93091qps 96475qps +3.2%

The newstack sections in framegraph are gone, and the cpu usage slightly went down in my test! See the total cpu usage of 3 tidb nodes in the metrics.

image

  • Without goroutine pool

image

  • With goroutine pool

image

I'll work on a global goroutine pool in TiDB. The goroutines with short lifetime benefit a lot from it.

This was referenced May 15, 2024
Open
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 21, 2024
@you06
copr: add ballast mem to reduce the runtime overhead during execution (…
b69f81b 
…#53407)

ref #52887
@ti-chi-bot ti-chi-bot mentioned this issue May 21, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 21, 2024
@ti-chi-bot
copr: add ballast mem to reduce the runtime overhead during execution (…
945d07c 
…#53407) (#53429)

ref #52887
@Yui-Song Yui-Song mentioned this issue May 22, 2024
Closed
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@you06 @RidRisR
copr: add ballast mem to reduce the runtime overhead during execution (…
13d36fa 
…pingcap#53407)

ref pingcap#52887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: implement global goroutine pool you06/tidb
2 participants
@hawkingrei @you06