Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LPUSH & RPUSH command API wrappers to GarnetClient #382

Merged
merged 17 commits into from
May 28, 2024
Merged

Add LPUSH & RPUSH command API wrappers to GarnetClient #382

merged 17 commits into from
May 28, 2024

Conversation

hishamco
Copy link
Contributor

/cc badrishc

@badrishc badrishc changed the title Add LPUSH & RPUSH commands Add LPUSH & RPUSH command API wrappers to GarnetClient May 14, 2024
@hishamco
Copy link
Contributor Author

Is the file-scope namespace the matter here?!!

@badrishc
Copy link
Contributor

/home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(44,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj]
/home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(46,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj]
/home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(129,2): error FINALNEWLINE: Fix final newline. Delete 1 characters. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj]
/home/runner/work/garnet/garnet/test/Garnet.test/RespListGarnetClientTests.cs(139,2): error FINALNEWLINE: Fix final newline. Delete 1 characters. [/home/runner/work/garnet/garnet/test/Garnet.test/Garnet.test.csproj]

@hishamco
Copy link
Contributor Author

Why you code style don't complain during the build in VS?

@hishamco
Copy link
Contributor Author

@badrishc is the process takes long to review, because I need to update to main whenever a new PR is merged

@badrishc
Copy link
Contributor

We will review it in the next day. Also note:

Contributor License Agreement is not agreed yet.

@hishamco
Copy link
Contributor Author

@microsoft-github-policy-service agree

TalZaccai
TalZaccai requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Added some comments...

libs/client/GarnetClientAPI/GarnetClientListCommands.cs Outdated Show resolved Hide resolved
libs/client/GarnetClientAPI/GarnetClientListCommands.cs Outdated Show resolved Hide resolved
libs/client/GarnetClientAPI/GarnetClientListCommands.cs Outdated Show resolved Hide resolved
libs/client/GarnetClientAPI/GarnetClientListCommands.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespListGarnetClientTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespListGarnetClientTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespListGarnetClientTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespListGarnetClientTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespListGarnetClientTests.cs Outdated Show resolved Hide resolved
@hishamco
Copy link
Contributor Author

Seems the review takes so long :)

@TalZaccai TalZaccai self-requested a review May 28, 2024 20:04
@TalZaccai TalZaccai merged commit 1671184 into microsoft:main May 28, 2024
23 checks passed
@hishamco hishamco deleted the list-commands branch May 28, 2024 20:29
@badrishc badrishc linked an issue Jun 5, 2024 that may be closed by this pull request
GarnetClient Extensions #375
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees

@TalZaccai TalZaccai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GarnetClient Extensions
3 participants
@hishamco @badrishc @TalZaccai