Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GarnetClient Extensions #375

Open
hishamco opened this issue May 11, 2024 · 7 comments
Open

GarnetClient Extensions #375

hishamco opened this issue May 11, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@hishamco
Copy link
Contributor

hishamco commented May 11, 2024

Feature request type

enhancement

Is your feature request related to a problem? Please describe

While there are few implemented commands for GarnetClient are you open to accepting PRs for implementing other commands on top of ExecuteForStringResultAsync() or ExecuteForStringArrayResultAsync()

I find myself writing some here https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/blob/main/src/OrchardCoreContrib.Garnet/Extensions/GarnetClientExtensions.cs

Also there are two in this PR https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/pull/127/files

Describe the solution you'd like

Add extension methods to GarnetClient

Describe alternatives you've considered

No response

Additional context

No response

@hishamco
Copy link
Contributor Author

/cc @TalZaccai

@badrishc
Copy link
Contributor

Yes, we are definitely open to accepting pull requests in this space. Thanks, and look forward to it!

@hishamco
Copy link
Contributor Author

Believe it or not yesterday I planned to start my library but I thought it be better to file an issue than hear the response, @badrishc could you please look for one of the extensions that I created if it's fine I can start push a PR

BTW shall we add it as extension methods or where should I add them, coz it's the first time to contribute here

@badrishc
Copy link
Contributor

These can be added at https://github.com/microsoft/garnet/tree/main/libs/client/GarnetClientAPI - you will see there are already files for different API categories, such as Sorted Set. You would add the new ones similarly.

@hishamco
Copy link
Contributor Author

hishamco commented May 13, 2024

Got it, I will start my PRs :)

One more thing but it might be breaking change why you are using Garnet.client namespace instead of Garnet.Client it is against the namespace rules

@badrishc
Copy link
Contributor

It was just a stylistic choice. We can leave it as Garnet.client - it is fine as long as our format style does not complain.

@darrenge darrenge added the enhancement New feature or request label May 15, 2024
@PaulusParssinen
Copy link
Contributor

PaulusParssinen commented May 17, 2024

+1 for following the standardized practice in .NET of PascalCasing the namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants