Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revision styles for workflow #4087

Merged
merged 5 commits into from
May 30, 2024
Merged

fix: revision styles for workflow #4087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f415015
fix: update placement of ModelParameterModal to left
lawvs May 4, 2024
d076b76
fix: toggle showFeaturesPanel in Header component
lawvs May 4, 2024
bd3b3a7
fix: types for MEMORY_DEFAULT
lawvs May 4, 2024
6720deb
fix: incorrect cursor style in field component
lawvs May 4, 2024
ef04c00
fix: update source.fixAll.eslint value to "explicit"
lawvs May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/.vscode/settings.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"prettier.enable": false,
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
zxhlyh marked this conversation as resolved.
Show resolved Hide resolved
},
"eslint.format.enable": true,
"[python]": {
Expand Down
2 changes: 1 addition & 1 deletion ...app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const ModelParameterModal: FC<ModelParameterModalProps> = ({
<PortalToFollowElem
open={open}
onOpenChange={setOpen}
placement='bottom-end'
placement='left'
crazywoola marked this conversation as resolved.
Show resolved Hide resolved
offset={4}
>
<div className='relative'>
Expand Down
4 changes: 2 additions & 2 deletions web/app/components/workflow/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ const Header: FC = () => {

const handleShowFeatures = useCallback(() => {
const {
showFeaturesPanel,
isRestoring,
setShowFeaturesPanel,
} = workflowStore.getState()
if (getNodesReadOnly() && !isRestoring)
return

setShowFeaturesPanel(true)
setShowFeaturesPanel(!showFeaturesPanel)
zxhlyh marked this conversation as resolved.
Show resolved Hide resolved
}, [workflowStore, getNodesReadOnly])

const handleCancelRestore = useCallback(() => {
Expand Down
4 changes: 2 additions & 2 deletions web/app/components/workflow/nodes/_base/components/field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ const Filed: FC<Props> = ({
toggle: toggleFold,
}] = useBoolean(true)
return (
<div className={cn(className, inline && 'flex justify-between items-center', supportFold && 'cursor-pointer')}>
<div className={cn(className, inline && 'flex justify-between items-center')}>
<div
onClick={() => supportFold && toggleFold()}
className='flex justify-between items-center'>
className={cn('flex justify-between items-center', supportFold && 'cursor-pointer')}>
zxhlyh marked this conversation as resolved.
Show resolved Hide resolved
<div className='flex items-center h-6'>
<div className='text-[13px] font-medium text-gray-700 uppercase'>{title}</div>
{tooltip && (
Expand Down
5 changes: 4 additions & 1 deletion web/app/components/workflow/nodes/_base/components/memory-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ type Props = {
canSetRoleName?: boolean
}

const MEMORY_DEFAULT: Memory = { window: { enabled: false, size: WINDOW_SIZE_DEFAULT } }
const MEMORY_DEFAULT: Memory = {
window: { enabled: false, size: WINDOW_SIZE_DEFAULT },
query_prompt_template: '',
}
zxhlyh marked this conversation as resolved.
Show resolved Hide resolved

const MemoryConfig: FC<Props> = ({
className,
Expand Down