Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revision styles for workflow #4087

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

lawvs
Copy link
Contributor

@lawvs lawvs commented May 4, 2024

Description

This pull request involves fixing some minor style issues.

  • Fix incorrect model position
Screen.Recording.2024-05-05.at.03.03.23.mov
  • Fix incorrect cursor style in the Panel component
Screen.Recording.2024-05-05.at.03.04.57.mov
  • Support toggle the Feature panel
Screenshot 2024-05-05 at 03 06 01

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

  • See video above

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@lawvs lawvs marked this pull request as ready for review May 4, 2024 19:10
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels May 4, 2024
@@ -152,7 +152,7 @@ const ModelParameterModal: FC<ModelParameterModalProps> = ({
<PortalToFollowElem
open={open}
onOpenChange={setOpen}
placement='bottom-end'
placement='left'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model parameter now properly stays on the left.

Screen.Recording.2024-05-07.at.13.16.12.mov

web/app/components/workflow/header/index.tsx Show resolved Hide resolved
lawvs added 5 commits May 15, 2024 12:24
Property 'query_prompt_template' is missing in type '{ window: { enabled: false; size: number; }; }' but required in type 'Memory'.ts(2741)
Code Actions' behavior on save in the editor has been modified from Booleans to an enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant