Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize home page #806

Closed
wants to merge 3 commits into from

Conversation

MichaelJRM
Copy link
Contributor

  • Updated tobbi & highlight to the most recent version
  • Used the custom highlight download tool to only pick the languages that are currently in use thus reducing the file size
  • Removed tobbi & highlight from all pages that do not use it
  • Created small plugin to fetch CSS asynchronously
  • Fixed header
  • Reordered requests to optimize FCP & LCP
Before After
before after

@Calinou Calinou added enhancement topic:theme Issues and PRs related to styling and scripts of the frontend labels Feb 16, 2024
@Calinou
Copy link
Member

Calinou commented Feb 16, 2024

Created small plugin to fetch CSS asynchronously

I'm concerned this could introduce FOUC (flash of unstyled content). If the CSS isn't available yet, the page will be displayed as raw HTML.

The rest looks good to me 🙂

@MichaelJRM
Copy link
Contributor Author

Yes I somehow didn't realize that before, It was only supposed to be used with CSS that's not critical :D

@MichaelJRM
Copy link
Contributor Author

Fixed a little bug with the fund button, I think I'm done here 🙂

_includes/footer.html Outdated Show resolved Hide resolved
@Calinou
Copy link
Member

Calinou commented Feb 21, 2024

Changes in this PR cause the homepage font size to change ever so slightly, resulting in line wrapping being broken for the tagline:

Before After (this PR)
image Screenshot_20240221_190614

There's already   between "waiting" and "for", so I don't know what's the cause of this.

Font selection is also different, causing all fonts to be slightly larger on my Linux setup:

Before After (this PR)
image image

Search icon alignment is broken on the Blog page:

Before After (this PR)
image image

@MichaelJRM
Copy link
Contributor Author

MichaelJRM commented Feb 21, 2024

Fixed all but: "Font selection is also different, causing all fonts to be slightly larger on my Linux setup:"
Could It be due to the added system-ui font?
What font do you have in your system?

--default-font-family: system-ui, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;

@MichaelJRM
Copy link
Contributor Author

I've tested on mac and windows and the font looks the same, I think the issue was that before this pr it wasn't picking your system font.

@coppolaemilio
Copy link
Member

I'm closing this PR as not planned. While the intentions are good, we are not going to be making significant changes to the current pages before we transition to the new site using hugo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:theme Issues and PRs related to styling and scripts of the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants