Optimize showcase page #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelJRM
force-pushed
the
optimize-showcase-page
branch
from
d06d4f4
to
e8b1e22
Compare
Calinou
added
enhancement
topic:theme
|
Buttons are no longer on a single line with this PR, which looks odd on desktop as they're very wide:
The spacing between buttons on mobile makes them look better than before this PR though. |
|
Yes this is a question I had, before this pr the left section didn't respect the 50% width limit thus the buttons stay in a single line, after this pr the limit is respected and they fall into a column. Should it stay like before or like now but instead of full width make them have the width of the largest element? |
|
I'm closing this PR as not planned. While the intentions are good, we are not going to be making significant changes to the current pages before we transition to the new site using hugo. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #806