Fix dangling surfaces in ReactHostImpl

[Kudo]

Summary:

Though the ReactHost.destroy() is not being used from OSS code, we use it at Expo for expo-dev-client to change loading apps from different dev servers. Without cleanup the mAttachedSurfaces, it will have dangling or duplicated attached surfaces that cause duplicated react trees.

This PR tries to cleanup the mAttachedSurfaces from destroying.

Changelog:

[ANDROID] [FIXED] - Fixed dangling mAttachedSurfaces after ReactHost.destroy()

Test Plan:

have to manually call ReactHost.destroy() and recreate the MainActivity without killing the process. then reload the app will startSurface for the same attached surfaces.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,527,863	-9
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,900,308	-10
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 00b3661
Branch: main

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@javache merged this pull request in c70d791.

[github-actions]

This pull request was successfully merged by @Kudo in c70d791.

^{When will my fix make it into a release? | How to file a pick request?}