-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-launcher][Android] Fixed LogBox
isn't working on the new architecture
#28602
Conversation
The Pull Request introduced fingerprint changes against the base commit: ae73d5b Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "0b359a1e901e9a05469fcf62f2687026359aaa72"
}
] Generated by PR labeler 🤖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could the issue relate to facebook/react-native#44393?
also if we want to customize something in our DevSupportManager, i would recommend to do it in DevLauncherBridgelessDevSupportManager than NonFinalBridgelessDevSupportManager. that would help the future react-native upgrade easier. (we would know which part is our customized and which part is just copied)
I think it's. Let me test that ;) |
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, let's keep it as-is. thanks for helping that.
Why
Closes ENG-12206.
How
It appears that the
LogBox
surface does not detach when the app reloads. This behavior is likely normal, but it causes issues with the developer menu. To address this, I have temporarily implemented a solution to detach the surface when the root view is destroyed.I'll try to investigate what is a default for RN apps and why it doesn't work with the menu. However, for now, that fix should be enough.
Test Plan