Fix markasread and breadCrumbcomp key prop error #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishpali17
commented
May 15, 2024
| @@ -20,7 +20,7 @@ export const metadata: Metadata = siteConfig; | |||
|
|
|||
| export default function RootLayout({ children }: { children: ReactNode }) { | |||
| return ( | |||
| <html lang="en"> | |||
| <html lang="en" suppressHydrationWarning> | |||
There was a problem hiding this comment.
Used for browser console error Extra attributes form the server: class,style;
manishpali17
commented
May 15, 2024
| stroke-width="2" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| strokeWidth="2" |
There was a problem hiding this comment.
Invaild Dom Property
manishpali17
commented
May 15, 2024
| </BreadcrumbItem> | ||
| )} | ||
| </> | ||
| return index !== array.length - 1 ? ( |
There was a problem hiding this comment.
Each child in a list should have a unique "key" prop
manishpali17
commented
May 15, 2024
src/components/CourseCard.tsx
Outdated
| @@ -4,6 +4,8 @@ import PercentageComplete from './PercentageComplete'; | |||
| import { PrimaryButton } from './buttons/PrimaryButton'; | |||
| import { SecondaryButton } from './buttons/SecondaryButton'; | |||
| import { useRouter } from 'next/navigation'; | |||
| import { Button } from './ui/button'; | |||
| import { ChevronRight } from 'lucide-react'; | |||
There was a problem hiding this comment.
missing imports
manishpali17
commented
May 15, 2024
| @@ -19,7 +19,7 @@ | |||
| "prisma:migrate": "prisma migrate deploy", | |||
| "db:seed": "prisma db seed", | |||
| "db:reset": "prisma migrate reset", | |||
| "prepare": "husky install", | |||
There was a problem hiding this comment.
Husky Install comment is Deprecated It's "husky" now
hkirat
reviewed
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #630
Resolves #629
Resolves #624
Resolves #623
Resolves #662
Checklist before requesting a review