Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Bookmarks seem broken #662

Closed
hkirat opened this issue May 17, 2024 · 4 comments
Closed

bug: Bookmarks seem broken #662

hkirat opened this issue May 17, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@hkirat
Copy link
Contributor

hkirat commented May 17, 2024

  1. All of my bookmarks seemed as marked
  2. In actuality I have only marked a few
  3. They are redirecting to the wrong place
Screenshot 2024-05-17 at 6 15 46 PM Screenshot 2024-05-17 at 6 15 41 PM Screenshot 2024-05-17 at 6 15 34 PM
@hkirat hkirat added the bug Something isn't working label May 17, 2024
@nimit9
Copy link
Contributor

nimit9 commented May 17, 2024

This might have happened due to the change where we removed the bookmark from course.

Might need to write a script to make the changes in db.

@manishpali17
Copy link
Contributor

hey there,

I was actually working on this issue but I forgot to push my code. Someone fixed it, but there is still a bug in src/components/bookmark/BookmarkList.tsx. it destucting wrong id from bookmark data which is causing worng redirection issue

bookmark error

and there also problem with src\db\course.ts it retiving cached bookmark which is not unique for current session

function

please take a look on my PR #631 @hkirat

@hkirat
Copy link
Contributor Author

hkirat commented May 19, 2024

Closed via f27ef33

@hkirat hkirat closed this as completed May 19, 2024
@manishpali17
Copy link
Contributor

Cheak issue #684 @hkirat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants