Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable in reflect_remove method in ReflectExt trait has wrong naming and wrong docs description #13390

Open
rewin123 opened this issue May 16, 2024 · 0 comments
Labels
A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@rewin123
Copy link

rewin123 commented May 16, 2024

How can Bevy's documentation be improved?

remove_reflect in docs
image
remove_reflect in implementation file
image

Problem

Mismatch in the name of the second remove_reflect variable between bevy::ecs::reflect::ReflectCommandExt and the implementation in ecs/reflect/entity_commands.rs

Called component_type_name in some parts, component_type_path in others

Expected behaviour

Since type_name was replaced by type_path during type registration, it is expected to be component_type_path everywhere else

Version

Bevy 0.13.2

@rewin123 rewin123 added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels May 16, 2024
@TrialDragon TrialDragon added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events A-Reflection Runtime information about types and removed S-Needs-Triage This issue needs to be labelled labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

No branches or pull requests

2 participants