Fixed incorrect behaviour of headless_renderer depending on image dimensions #13388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
May 16, 2024
bugsweeper
force-pushed
the
undepend_headless_renderer_example_from_image_dimensions
branch
from
423118e
to
7bff4ec
Compare
mockersf
requested changes
May 16, 2024
There was a problem hiding this comment.
It doesn't work.
If I ask for an image of 1080x1080:
thread '<unnamed>' panicked at examples/app/headless_renderer.rs:517:49:
range end index 4320 out of range for slice of length 2560
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `headless_renderer::update`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!
mockersf
reviewed
May 16, 2024
Co-authored-by: François Mockers <francois.mockers@vleue.com>
|
Looks like problem of 1080x1080 was in last row, which somehow is reminder of division by aligned_row_bytes. I cut off remaining rows, this reinsurance works well alone, but i will keep them both. Literaly buffer has length 5529600, aligned row has length 4352, it turns out 1270 full rows (not 1080!) and 2560 bytes in partial row |
|
@mockersf May I ask you for review? |
mockersf
approved these changes
May 19, 2024
mockersf
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
headless_rendererexample #13384 .Solution
Testing