Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability improvements to the NumberInput component #1588

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Usability improvements to the NumberInput component #1588

wants to merge 9 commits into from

Commits on Feb 19, 2024

  1. GraphiteEditor#313 up/down arrows (7th feature) 

    TODO: immediately update
    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9dcc8ac View commit details
    Browse the repository at this point in the history

  2. GraphiteEditor#313 up/down arrows: immediately update 

    REVIEW Q:
* if in `.svelte` `export let` then MUST I add in `.rs` `NumberInput` this field?
specifically: `export let defaultValue: number = 0;`
* also can there be any order of non-export fields in `.svelte` or it MUST stay after `export` fields?
    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b6cab39 View commit details
    Browse the repository at this point in the history

  3. GraphiteEditor#313 holding arrows down (8th feature) 

    TODO:
* `ctrl` / `shift` to diff paces
* undo on `Esc`
    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    14373e1 View commit details
    Browse the repository at this point in the history

  4. GraphiteEditor#313 holding arrows down: cancel on Esc

    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dd87d8f View commit details
    Browse the repository at this point in the history

  5. GraphiteEditor#313 ctrl+scroll

    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ed0eaba View commit details
    Browse the repository at this point in the history

  6. GraphiteEditor#313 hovering and then key downs (with Ctrl)

    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8240fc0 View commit details
    Browse the repository at this point in the history

  7. maybe need to add many more defaultValue

    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f555040 View commit details
    Browse the repository at this point in the history

  8. GraphiteEditor#1588 fix lint errors

    @Nikita-str @Keavon
    Nikita-str authored and Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    14b054e View commit details
    Browse the repository at this point in the history

  9. Code review, WIP

    @Keavon
    Keavon committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    09dfb50 View commit details
    Browse the repository at this point in the history