Usability improvements to the NumberInput component #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nikita-str
added a commit
to Nikita-str/Graphite
that referenced
this pull request
Jan 27, 2024
Keavon
changed the title
|
Here's an incomplete set of notes from my QA testing and code review. I'm not done. But I'm leaving them here. If you'd to take any of these on, feel free, or you can wait till I'm done (and I might fix some of them myself).
|
Keavon
force-pushed
the
web--number-input-widget
branch
from
69af8f7
to
56e6dc1
Compare
Keavon
pushed a commit
to Nikita-str/Graphite
that referenced
this pull request
Feb 19, 2024
Keavon
force-pushed
the
web--number-input-widget
branch
from
56e6dc1
to
40d2f28
Compare
TODO: immediately update
REVIEW Q: * if in `.svelte` `export let` then MUST I add in `.rs` `NumberInput` this field? specifically: `export let defaultValue: number = 0;` * also can there be any order of non-export fields in `.svelte` or it MUST stay after `export` fields?
TODO: * `ctrl` / `shift` to diff paces * undo on `Esc`
Keavon
force-pushed
the
web--number-input-widget
branch
from
40d2f28
to
09dfb50
Compare
Keavon
force-pushed
the
master
branch
2 times, most recently
from
7bf7f92
to
5f4960d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #313
TODO: File an issue for these completed features
done (features from 7th to 14th inclusively from the issue):
Shiftby 10, withCtrl(if value isn't Integer) by 0.1Ctrl+scrollon hover to inc/dec valueCtrl+{C\V\/(value = 1/value) \Backspace(revert to default) \Enter\-(change sign of value)}. MAYBE not all of them should useCtrlUnit conversion(6th feature) and cleaning up floating point imprecision(15th feature) need to be discussed before doing them