Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libmve bug #359

Closed
wants to merge 1 commit into from
Closed

Conversation

GravisZro
Copy link
Contributor

Correctly dereference the arrays so you don't actually convert the value at the array index to a pointer.

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

I'm not sure how this got messed up. Anyway, this is the fix which also prevents annoying warnings. Does libmve work? I have no idea but if nothing else, I fixed a warning.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Correctly dereference the arrays so you don't actually convert the value
at the array index to a pointer.
@GravisZro GravisZro mentioned this pull request May 17, 2024
13 tasks
@JeodC JeodC added the bugfix Pull request fixes one or more bugs label May 20, 2024
@JeodC JeodC requested a review from winterheart May 20, 2024 01:37
@Lgt2x
Copy link
Collaborator

Lgt2x commented May 22, 2024

This file will be removed when changing the third-party in #289 , we can safely close this.

@Lgt2x Lgt2x closed this May 22, 2024
@GravisZro GravisZro deleted the fix/libmve branch May 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request fixes one or more bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants