-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64-bit fixes #355
64-bit fixes #355
Conversation
Any overlap with #354 ? |
6ecaa01
to
3dfa765
Compare
Yes. I suppose I'll remove the overlap. |
I swear it's like any time I make a contribution that someone just MUST get in and do the same thing. sigh |
3ffe640
to
888be05
Compare
ecc156d
to
35a1ad9
Compare
@winterheart issues resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks! Diff looks good, I'll give it a go on Windows and let @winterheart approve additionally. Good idea to split it in multiple PR for easier reviewing
Switch all the (u)long types to (u)int32_t where appropriate.
Description
Cleaned up the Win32 API arguments(Windows x64 build #354 beat me to it by like 12 minutes)Fixes the libmve code (failed to dereference the array)(moved into Fix libmve bug #359)Fixes the network code which was using the incorrect size due to use of "long"(moved into Replace ioctl with fcntl, fix ioctlsocket calls (64-bit fix) #356)Pull Request Type
Checklist