left_sidebar: Align more-topics indicator on topic grid. #30127
Merged
+34
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlstolley
added
integration review
timabbott
reviewed
May 18, 2024
karlstolley
force-pushed
the
searching-more-topics
branch
from
7b19d40
to
9705c97
Compare
timabbott
reviewed
May 21, 2024
| @@ -337,7 +337,7 @@ export function initialize({ | |||
| }): void { | |||
| $("#stream_filters").on( | |||
| "click", | |||
| ".sidebar-topic-check, .topic-name, .topic-markers-and-controls", | |||
| ".sidebar-topic-check, .sidebar-topic-name, .topic-markers-and-controls", | |||
There was a problem hiding this comment.
This line in topic_popover.js looks like it might need to also be updated, with some care around how the popover is also declared for .inbox-row .inbox-topic-menu
url = $elt.closest("li").find(".topic-name").expectOne().prop("href");
There was a problem hiding this comment.
Great catch. The if (instance.reference.classList.contains("inbox-topic-menu")) conditional appears to isolate the line you pointed out safely from the Inbox popover, and manual testing confirms that. But maybe there's something else I'm overlooking where I'm not exercising due care?
There was a problem hiding this comment.
Ahh, yes, quite so, reading the code to notice that block is the "some care" required :)
karlstolley
force-pushed
the
searching-more-topics
branch
from
9705c97
to
eeb921a
Compare
|
Merged, thanks @karlstolley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the
.searching-for-more-topicsindicator participating in the same grid used on other topic rows. A prep commit just flattens a selector in the area.CZO discussion
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: