Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar_alerts: Convert module to TypeScript. #30123

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

afeefuddin
Copy link
Collaborator

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

web/src/navbar_alerts.ts Outdated Show resolved Hide resolved
@andersk andersk added the area: typescript migration Issues for migrating Zulip to TypeScript label May 20, 2024
@afeefuddin
Copy link
Collaborator Author

The cancelled check seems unrelated.

@zulipbot
Copy link
Member

zulipbot commented Jun 3, 2024

Heads up @afeefuddin, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@timabbott
Copy link
Sponsor Member

The cancelled check seems unrelated.

Yeah, that usually just means GitHub Action's infrastructure didn't run it, often because a new version was pushed.

@timabbott timabbott merged commit 394e8fc into zulip:main Jun 3, 2024
14 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @afeefuddin!

@afeefuddin afeefuddin deleted the navbar_alerts branch June 3, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript migration Issues for migrating Zulip to TypeScript size: L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants