portico: Correct help navigation outlines. #30118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/design, @zulip/server-misc, @zulip/server-user-docs members, this pull request was labeled with the "design", "area: documentation (user)", "area: portico" labels, so you may want to check it out! |
12 tasks
|
@alya just pointing this PR out, since Lauryn & I accidentally overlapped on this work and I put in some fixes that weren't part of the original PR that I've since closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an ugly focus ring in the help navbars. It consolidates the CSS to make it applicable to all sidebar navigation items (not just those in list items), and uses
:focus-visibleto make a more consistent and accessible presentation of focused elements--including the currently-highlighted element.It also now makes navbar-item highlighting uniform across Firefox and Chrome.
Note that this is a good opportunity for a design pass on the highlighted and focus styles, which may well be overwrought.
Fixes: #28745.
Screenshots and screen captures: