Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent_view: Remove side borders. #30109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanagr
Copy link
Member

@amanagr amanagr commented May 16, 2024

before after
Screenshot 2024-05-16 at 10 00 22 AM Screenshot 2024-05-16 at 10 00 37 AM
before after
Screenshot 2024-05-16 at 9 59 44 AM Screenshot 2024-05-16 at 9 59 30 AM

Ensuring focus borders don't break

Screenshot 2024-05-16 at 10 15 01 AM Screenshot 2024-05-16 at 10 14 47 AM Screenshot 2024-05-16 at 10 14 30 AM

@amanagr amanagr force-pushed the recent_view_borders branch 2 times, most recently from 59379a4 to 6c9e6c1 Compare May 16, 2024 04:51
@timabbott timabbott added the deployed on chat.zulip.org Added by maintainers when a PR is currently being tested on chat.zulip.org. label May 16, 2024
@timabbott
Copy link
Sponsor Member

I'm not sure about the alignment of the options -- I'd expect them to be aligned with the message view header. Checked inbox, and there it's even more intended than that, which probably isn't great either.

@amanagr
Copy link
Member Author

amanagr commented May 20, 2024

By message view header, do you mean the icon at the start of the header? #30134 has that version, we can deploy that directly.

Screenshot 2024-05-20 at 2 17 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed on chat.zulip.org Added by maintainers when a PR is currently being tested on chat.zulip.org. size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants