Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blue secondary focus outline from help/api center pages #28745

Open
timabbott opened this issue Jan 30, 2024 · 10 comments · May be fixed by #30118
Open

Remove blue secondary focus outline from help/api center pages #28745

timabbott opened this issue Jan 30, 2024 · 10 comments · May be fixed by #30118

Comments

@timabbott
Copy link
Sponsor Member

As detailed in this chat.zulip.org thread, there's a buggy double-focus outline in the left sidebar of the help/api documentation pages (localhost:9991/help in the development environment):

Screenshot-2024-01-25-at-11 33 38AM

The current proposed fix is to just remove the blue one, which is likely from our own CSS, and just keep the white/browser focus outline, but use your judgement when you've tracked down the code in question.

@zulipbot
Copy link
Member

Hello @zulip/design, @zulip/server-user-docs members, this issue was labeled with the "design", "area: documentation (user)" labels, so you may want to check it out!

@vighneshbhat9945
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @vighneshbhat9945! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@ankitsuryawanshi9892
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

@ankitsuryawanshi9892 This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

@zulipbot
Copy link
Member

zulipbot commented Feb 9, 2024

@vighneshbhat9945 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@mk0904
Copy link
Collaborator

mk0904 commented Feb 14, 2024

@zulipbot claim

@zulipbot
Copy link
Member

Hello @mk0904, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@mk0904
Copy link
Collaborator

mk0904 commented Feb 15, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 25, 2024

@mk0904 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

CIC4DA added a commit to CIC4DA/zulip that referenced this issue Mar 4, 2024
CIC4DA added a commit to CIC4DA/zulip that referenced this issue Mar 14, 2024
laurynmm added a commit to CIC4DA/zulip that referenced this issue May 16, 2024
Sets the outline for anchor elements in the sidebar
to be the same color as the highlighted background
color.

Fixes: zulip#28745

Co-authored-by: Karl Stolley <karl@zulip.com>
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
laurynmm added a commit to CIC4DA/zulip that referenced this issue May 16, 2024
Sets the outline for anchor elements in the sidebar
to be the same color as the highlighted background
color.

Fixes: zulip#28745

Co-authored-by: Karl Stolley <karl@zulip.com>
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
karlstolley added a commit to karlstolley/zulip that referenced this issue May 16, 2024
@karlstolley karlstolley linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants