Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.DynLib: compile error if attempt to lookup a fn pointer with an unspecified callconv #19842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/std/dynamic_library.zig
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,19 @@ pub const DynLib = struct {
}

pub fn lookup(self: *DynLib, comptime T: type, name: [:0]const u8) ?T {
switch (@typeInfo(T)) {
.Pointer => |pointer| {
switch (@typeInfo(pointer.child)) {
.Fn => |function| {
if (function.calling_convention == .Unspecified) {
@compileError("callconv cannot be .Unspecified for: " ++ @typeName(T));
}
},
else => {},
}
},
else => @compileError("expected a pointer type"),
}
return self.inner.lookup(T, name);
}
};
Expand Down