Run: add output directory arguments #19826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobly0
force-pushed
the
outdirarg
branch
10 times, most recently
from
5888d16
to
4f6f558
Compare
This replaces `extra_file_dependencies` with support for lazy paths. Also assert output file basenames are not empty, avoid improper use of field default values, ensure stored strings are duplicated, and prefer `ArrayListUnmanaged` to discourage misuse of direct field access which wouldn't add step dependencies.
* `doc/langref` formatting
* upgrade `.{ .path = "..." }` to `b.path("...")`
* avoid using arguments named `self`
* make `Build.Step.Id` usage more consistent
* add `Build.pathResolve`
* use `pathJoin` and `pathResolve` everywhere
* make sure `Build.LazyPath.getPath2` returns an absolute path
jacobly0
force-pushed
the
outdirarg
branch
2 times, most recently
from
80474bc
to
725f2f9
Compare
This allows running commands that take an output directory argument. The main thing that was needed for this feature was generated file subpaths, to allow access to the files in a generated directory. Additionally, a minor change was required to so that the correct directory is created for output directory args.
andrewrk
approved these changes
May 9, 2024
|
I suspect this caused #19938. Edit: indeed, when I revert this commit, the regression disappears. |
This was referenced May 11, 2024
linusg
added a commit
to linusg/any-pointer
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
linusg
added a commit
to linusg/parser-toolkit
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
linusg
added a commit
to linusg/zig-args
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
linusg
added a commit
to linusg/zigline
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
linusg
added a commit
to linusg/zig-build-macos-sdk
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
alimpfard
pushed a commit
to alimpfard/zigline
that referenced
this pull request
May 17, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
ikskuh
pushed a commit
to ikskuh/zig-args
that referenced
this pull request
May 18, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
ikskuh
pushed a commit
to ikskuh/parser-toolkit
that referenced
this pull request
May 18, 2024
The 'path' union field got removed upstream. See: ziglang/zig#19826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running commands that take an output directory argument. The main thing that was needed for this feature was generated file subpaths, to allow access to the files in a generated directory. Additionally, a minor change was required to so that the correct directory is created for output directory args.
Also adds run step input files includes lots of cleanup.