fix: make zig cc pass -l/-L like Clang/GCC for ELF
#19818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the way `zig cc` passes `-l/-L` flags for ELF linking consistent with Clang and GCC. Closes ziglang#19699
|
@motiejus @kubkon This PR builds on the functionality implemented in #15743 and should also fix |
kubkon
requested changes
May 1, 2024
| @@ -769,6 +769,54 @@ pub fn addCliTests(b: *std.Build) *Step { | |||
| step.dependOn(&cleanup.step); | |||
| } | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
This set of tests belongs in linker tests in test/link/elf.zig. I also don't understand why can't it be orchestrated using the build system? Why do you need to invoke zig exe via addSystemCommand? exe.linkSystemLibrary("foo") emits as -lfoo fwiw. Did you actually have a look at test/link/elf.zig? We do have a substantial amount of tests that rely on emitting and linking against system libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my attempt to fix #19699 by making the way
zig ccpasses-l/-Lflags for ELF linking consistent with Clang and GCC.I've added a test case that mimics the example in the issue description. Without the changes this PR makes to
src, the new test case fails as expected withI am not sure if
test/tests.zigis the best place for it - I couldn't find a good way to test this intest/link/elf.zigortest/standalone.