Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix.renameW: Handle DIRECTORY_NOT_EMPTY more generally #19804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

posix.renameW: Handle DIRECTORY_NOT_EMPTY more generally #19804

wants to merge 1 commit into from

Commits on Apr 29, 2024

  1. posix.renameW: Handle DIRECTORY_NOT_EMPTY more generally 

    Before this commit, the DIRECTORY_NOT_EMPTY/FILE_IS_A_DIRECTORY/NOT_A_DIRECTORY statuses were assumed only to be possible when using `FILE_RENAME_INFORMATION_EX` and `FILE_RENAME_POSIX_SEMANTICS`, but that has empirically been shown to be false; a networked samba share can return the DIRECTORY_NOT_EMPTY status from `FILE_RENAME_INFORMATION` (which doesn't support `FILE_RENAME_POSIX_SEMANTICS`).

`FILE_IS_A_DIRECTORY` and `NOT_A_DIRECTORY` were not proven to be possible, but they were also moved to the outer switch just in case.

Fixes ziglang#19785
    @squeek502
    squeek502 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    61e4fc4 View commit details
    Browse the repository at this point in the history