sample: openamp_rsc_table: enable colibri imx7d #72970
Open
+254
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: IPC
zephyrbot
requested review from
arnopo,
carlocaione,
danieldegrasse,
dbaluta,
decsny,
dleach02,
galak,
ithinuel,
iuliana-prodan,
JiafeiPan,
kartben,
MaureenHelm,
microbuilder,
nashif and
yvanderv
ithinuel
previously approved these changes
May 18, 2024
jlh-makeen
force-pushed
the
sample/openamp_rsc_table/colibri_imx7d
branch
2 times, most recently
from
16d6573
to
2972e30
Compare
|
Sorry for the noise, and force-pushes I had to fix typos in the comments 🙃 |
jlh-makeen
force-pushed
the
sample/openamp_rsc_table/colibri_imx7d
branch
2 times, most recently
from
eca2b23
to
a86e909
Compare
iuliana-prodan
previously approved these changes
May 20, 2024
jlh-makeen
commented
May 20, 2024
jlh-makeen
force-pushed
the
sample/openamp_rsc_table/colibri_imx7d
branch
from
229ff2f
to
d1ed834
Compare
|
Apparently the latest rebase on the latest main fails CI on the frdm_k64f. |
jlh-makeen
force-pushed
the
sample/openamp_rsc_table/colibri_imx7d
branch
from
d1ed834
to
487c5b6
Compare
iuliana-prodan
previously approved these changes
May 21, 2024
|
@ithinuel Are you willing to give another look at this PR now that it passes CI ? |
|
@danieldegrasse Are you interested in reviewing this PR too ? 😄 |
ithinuel
previously approved these changes
May 23, 2024
dbaluta
reviewed
May 23, 2024
| @@ -9,6 +9,9 @@ zephyr_sources( | |||
| soc_clk_freq.c | |||
| ) | |||
There was a problem hiding this comment.
Have you found anything ? 🙃
I don't think I have misspelled resource in the sources have I ?
carlocaione
previously approved these changes
May 23, 2024
kartben
requested changes
May 23, 2024
Comment on lines
383
to
411
| #Copy zephyr_openamp_rsc_table.elf to /lib/firmware on your board | ||
| modprobe imx_rproc | ||
| modprobe virtio_rpmsg_bus | ||
| modprobe rpmsg_tty | ||
|
|
||
| #Request RPROC to load the M4 image | ||
| echo stop > /sys/class/remoteproc/remoteproc0/state | ||
| echo zephyr_openamp_rsc_table.elf > /sys/class/remoteproc/remoteproc0/firmware | ||
| echo start > /sys/class/remoteproc/remoteproc0/state | ||
|
|
||
| #dmesg will detail the boot process: | ||
| dmesg | ||
| [ 497.120499] remoteproc remoteproc0: stopped remote processor imx-rproc | ||
| [ 497.138938] remoteproc remoteproc0: powering up imx-rproc | ||
| [ 497.168735] remoteproc remoteproc0: Booting fw image zephyr_openamp_rsc_table.elf, size 1267076 | ||
| [ 497.184826] rproc-virtio rproc-virtio.1.auto: assigned reserved memory node vdev0buffer0@90002000 | ||
| [ 497.221395] virtio_rpmsg_bus virtio0: rpmsg host is online | ||
| [ 497.233806] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x400 | ||
| [ 497.236666] rproc-virtio rproc-virtio.1.auto: registered virtio0 (type 7) | ||
| [ 497.259822] remoteproc remoteproc0: remote processor imx-rproc is now up | ||
| [ 497.293913] virtio_rpmsg_bus virtio0: creating channel rpmsg-client-sample addr 0x401 | ||
| [ 497.308388] rpmsg_client_sample virtio0.rpmsg-client-sample.-1.1025: new channel: 0x401 -> 0x401! | ||
| [ 497.337969] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x402 | ||
|
|
||
| ls /dev | grep ttyRPMSG | ||
| ttyRPMSG0 -> used for zephyr shell interface | ||
| ttyRPMSG1 -> used for sample interface |
There was a problem hiding this comment.
The below should provide better syntax coloring
Suggested change
| #Copy zephyr_openamp_rsc_table.elf to /lib/firmware on your board | |
| modprobe imx_rproc | |
| modprobe virtio_rpmsg_bus | |
| modprobe rpmsg_tty | |
| #Request RPROC to load the M4 image | |
| echo stop > /sys/class/remoteproc/remoteproc0/state | |
| echo zephyr_openamp_rsc_table.elf > /sys/class/remoteproc/remoteproc0/firmware | |
| echo start > /sys/class/remoteproc/remoteproc0/state | |
| #dmesg will detail the boot process: | |
| dmesg | |
| [ 497.120499] remoteproc remoteproc0: stopped remote processor imx-rproc | |
| [ 497.138938] remoteproc remoteproc0: powering up imx-rproc | |
| [ 497.168735] remoteproc remoteproc0: Booting fw image zephyr_openamp_rsc_table.elf, size 1267076 | |
| [ 497.184826] rproc-virtio rproc-virtio.1.auto: assigned reserved memory node vdev0buffer0@90002000 | |
| [ 497.221395] virtio_rpmsg_bus virtio0: rpmsg host is online | |
| [ 497.233806] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x400 | |
| [ 497.236666] rproc-virtio rproc-virtio.1.auto: registered virtio0 (type 7) | |
| [ 497.259822] remoteproc remoteproc0: remote processor imx-rproc is now up | |
| [ 497.293913] virtio_rpmsg_bus virtio0: creating channel rpmsg-client-sample addr 0x401 | |
| [ 497.308388] rpmsg_client_sample virtio0.rpmsg-client-sample.-1.1025: new channel: 0x401 -> 0x401! | |
| [ 497.337969] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x402 | |
| ls /dev | grep ttyRPMSG | |
| ttyRPMSG0 -> used for zephyr shell interface | |
| ttyRPMSG1 -> used for sample interface | |
| #Copy zephyr_openamp_rsc_table.elf to /lib/firmware on your board | |
| $ modprobe imx_rproc | |
| $ modprobe virtio_rpmsg_bus | |
| $ modprobe rpmsg_tty | |
| #Request RPROC to load the M4 image | |
| $ echo stop > /sys/class/remoteproc/remoteproc0/state | |
| $ echo zephyr_openamp_rsc_table.elf > /sys/class/remoteproc/remoteproc0/firmware | |
| $ echo start > /sys/class/remoteproc/remoteproc0/state | |
| #dmesg will detail the boot process: | |
| $ dmesg | |
| [ 497.120499] remoteproc remoteproc0: stopped remote processor imx-rproc | |
| [ 497.138938] remoteproc remoteproc0: powering up imx-rproc | |
| [ 497.168735] remoteproc remoteproc0: Booting fw image zephyr_openamp_rsc_table.elf, size 1267076 | |
| [ 497.184826] rproc-virtio rproc-virtio.1.auto: assigned reserved memory node vdev0buffer0@90002000 | |
| [ 497.221395] virtio_rpmsg_bus virtio0: rpmsg host is online | |
| [ 497.233806] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x400 | |
| [ 497.236666] rproc-virtio rproc-virtio.1.auto: registered virtio0 (type 7) | |
| [ 497.259822] remoteproc remoteproc0: remote processor imx-rproc is now up | |
| [ 497.293913] virtio_rpmsg_bus virtio0: creating channel rpmsg-client-sample addr 0x401 | |
| [ 497.308388] rpmsg_client_sample virtio0.rpmsg-client-sample.-1.1025: new channel: 0x401 -> 0x401! | |
| [ 497.337969] virtio_rpmsg_bus virtio0: creating channel rpmsg-tty addr 0x402 | |
| $ ls /dev | grep ttyRPMSG | |
| ttyRPMSG0 -> used for zephyr shell interface | |
| ttyRPMSG1 -> used for sample interface |
There was a problem hiding this comment.
I'm gonna try that and rebuild the docs to see how it looks :-)
There was a problem hiding this comment.
Does indeed provide syntax coloring ;)
Add RPMSG/OpenAMP ressource table definition for the IMX7d SOC. Signed-off-by: Jérémy LOCHE - MAKEEN Energy <jlh@makeenenergy.com>
Add a prompt to ROMSTART_RELOCATION_ROM configs to allow projects config file selection. This simplifies the usage in samples/app for board porting. Signed-off-by: Jérémy LOCHE - MAKEEN Energy <jlh@makeenenergy.com>
Enable openamp sample for Toradex Colibri IMX7D. Tested with LTS BSP 6.6.0 on kernel 6.1.83. Signed-off-by: Jérémy LOCHE - MAKEEN Energy <jlh@makeenenergy.com>
jlh-makeen
dismissed stale reviews from carlocaione, ithinuel, and iuliana-prodan
via
a652555
jlh-makeen
force-pushed
the
sample/openamp_rsc_table/colibri_imx7d
branch
from
487c5b6
to
a652555
Compare
|
Took a chance to rebase, correct the docs and tested building docs to check the updates. |
jlh-makeen
requested review from
kartben,
carlocaione,
ithinuel,
iuliana-prodan and
dbaluta
kartben
approved these changes
May 24, 2024
iuliana-prodan
approved these changes
May 24, 2024
|
Any more comments on this PR ? |
|
Assignee approval is needed for PRs to merge- @carlocaione can you refresh your +1 if everything looks good? |
|
@carlocaione Hope you can get time to give a last look at this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #71684 we can now properly boot the M4 core on IMX7D using Linux RPROC.
Adds prompts to the PR #71684 config flags so they can be used in the board's config files.
Adds the necessary definition for the .resource_table for the imx7d soc.
Adds support for the Toradex Colibri IMX7D board for openamp_rsc_table.
This is the first IMX7D board to be officially supported in a openamp_rsc_table sample.
It provides a template for porting other board by providing documentation and a base configuration for the SOC.
Note that this sample is supposed to be loaded using Linux RPROC as we only use the .elf file to boot it from Linux.
This makes sure Linux has fine control over the M4 core state.
Booting from U-boot is not directly supported.
It might be possible to boot from U-boot if ROMSTART_RELOCATION_ROM is disabled and BUILD_OUTPUT_BIN is enabled.
Tested on official Colibri IMX7D on Viola Carrier board running BSP 6.6.0 Minimal image with Linux Kernel 6.1.83.