logging: log_output: Prevent redundant flush with zero-length data #72967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
reviewed
May 20, 2024
kwd-doodling
force-pushed
the
log_output_flush
branch
from
f860321
to
c4393fb
Compare
nordic-krch
approved these changes
May 21, 2024
There's such a case captured. When log immediate mode is enabled, each log message is output per character. However, "log_output_flush()" function is still called with zero data length at the end of "log_output_process()". Better to make "buffer_write()" returns immediatley if buffer data length is zero. Signed-off-by: Dong Wang <dong.d.wang@intel.com>
kwd-doodling
force-pushed
the
log_output_flush
branch
from
c4393fb
to
631d92a
Compare
dcpleung
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's such a case captured. When log immediate mode is enabled, each log message is output per character. However, "log_output_flush()" function is still called with zero data length at the end of "log_output_process()". Better to make "log_output_flush()" returns immediatley if buffer data length is zero.