Renesas: Smartbond: Crypto Driver Update #72956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Crypto / RNG
area: Samples
zephyrbot
requested review from
andrzej-kaczmarek,
blauret,
ceolin,
kartben and
nashif
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
2 times, most recently
from
7e18def
to
f155906
Compare
ydamigos
reviewed
May 20, 2024
drivers/crypto/crypto_smartbond.c
Outdated
| * write access while XiP, should result in raising busfault | ||
| * exception. | ||
| */ | ||
| return crypto_swap_word(data); |
There was a problem hiding this comment.
Suggested change
| return crypto_swap_word(data); | |
| return SWAP32(__UNALIGNED_UINT32_READ(data)); |
There was a problem hiding this comment.
Or better use API functions like sys_get_le32()/sys_get_be32().
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
from
f155906
to
5f38bec
Compare
ydamigos
reviewed
May 20, 2024
There was a problem hiding this comment.
We need a "consumer" for this, don't we?
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
2 times, most recently
from
655e8a7
to
614c2f2
Compare
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
from
614c2f2
to
302c732
Compare
ydamigos
approved these changes
May 21, 2024
blauret
previously approved these changes
May 21, 2024
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
2 times, most recently
from
89c7129
to
b14ab57
Compare
andrzej-kaczmarek
previously approved these changes
May 22, 2024
This commit should fix the followings: 1. Suppress compiler warnings 2. Cryptographic mode should first be exercised before applying the secure key 3. In-memory word swap operations should be omitted as the key should reside in the flash memory and so any write access should raise a busfault exception Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
This commit should add support for the DA1469x Pro DevKit. Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
This commit should add support for the DA1469x Pro DevKit. Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
ioannis-karachalios
dismissed stale reviews from andrzej-kaczmarek and blauret
via
2c5a49e
ioannis-karachalios
force-pushed
the
da1469x-crypto-update
branch
from
b14ab57
to
2c5a49e
Compare
|
@ceolin ping |
blauret
approved these changes
May 29, 2024
ceolin
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix few Crypto driver issues and add support to the Crypto tests/samples suite.