net: lib: coap_client: observe-related fixes #72948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glarsennordic ATTN |
tautologyclub
force-pushed
the
fixes-for-coap-client-observes
branch
2 times, most recently
from
abcc6ad
to
dde8ad7
Compare
rlubos
previously approved these changes
May 20, 2024
jukkar
reviewed
May 20, 2024
subsys/net/lib/coap/coap_client.c
Outdated
| @@ -779,6 +781,16 @@ static int handle_response(struct coap_client *client, const struct coap_packet | |||
| } | |||
| } | |||
|
|
|||
| /* MID-based deduplication */ | |||
| uint16_t response_id = coap_header_get_id(response); | |||
There was a problem hiding this comment.
We usually try to introduce variables at the start of the block
There was a problem hiding this comment.
That policy isn't even followed by the function I added the variable to :D but sure, fixed
|
LGTM! But being honest, I don't really have any horses in this race, other than the |
An earlier pull request implementing observe support was merged too hastily. It had a few issues: 1. The predicate for whether a request should be marked not ongoing was wrong (it checked ret != 0 instead of ret < 0) 2. Without observes in mind, MID-based deduplication is not a required feature. Deduplication was handled implicitly - the exchange would get dropped after the first response anyway, so duplicate responses would not get matched to anything. But with observes, there are several responses in an exchange. This commit adds this. 3. Using coap_request_is_observe(&internal_req->request) in the response handler requires the whole request to stay in scope for the lifetime of the observation, which I observed was not always the case. Adding an is_observe bool to the internal struct improved stability significantly. With these fixes, GETs with observe option works very well. Signed-off-by: Benjamin Lindqvist <benjamin@eub.se>
tautologyclub
force-pushed
the
fixes-for-coap-client-observes
branch
from
dde8ad7
to
e983684
Compare
rlubos
approved these changes
May 21, 2024
jukkar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier pull request implementing observe support was merged too hastily. It had a few issues:
With these fixes, GETs with observe option works very well.