Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include: drivers: gpio: fix gpio_dt_flags_t overflow #72946

Merged
merged 1 commit into from
May 28, 2024
Merged

include: drivers: gpio: fix gpio_dt_flags_t overflow #72946

merged 1 commit into from
May 28, 2024

Conversation

ajarmouni-st
Copy link
Collaborator

@ajarmouni-st ajarmouni-st commented May 17, 2024 •
edited

when GPIO_INT_WAKEUP flag is used in a DT gpios property, the gpio_dt_flags_t var that holds the flags overflows.

@ajarmouni-st ajarmouni-st marked this pull request as ready for review May 17, 2024 13:55
@zephyrbot zephyrbot added Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. area: GPIO labels May 17, 2024
@zephyrbot zephyrbot requested a review from mnkp May 17, 2024 13:55
@ajarmouni-st ajarmouni-st requested review from mmahadevan108 and mnkp and removed request for mnkp May 17, 2024 13:56
@ajarmouni-st ajarmouni-st requested a review from ubieda May 21, 2024 09:37
henrikbrixandersen
henrikbrixandersen requested changes May 22, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply move GPIO_INT_WAKEUP to bit 6?

@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label May 22, 2024
@zephyrbot zephyrbot requested review from decsny and galak May 22, 2024 12:49
henrikbrixandersen
henrikbrixandersen requested changes May 22, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please update the commit message to describe this new solution better.

@ajarmouni-st
include: drivers: gpio: fix gpio_dt_flags_t overflow
7b5c565 
when GPIO_INT_WAKEUP flag is used in a DT gpios property
the gpio_dt_flags_t var that holds the flags overflows
Hence moving GPIO_INT_WAKEUP flag from bit 28 to bit 6

Signed-off-by: Abderrahmane Jarmouni <abderrahmane.jarmouni-ext@st.com>
@ajarmouni-st
Copy link
Collaborator Author

Looks good, but please update the commit message to describe this new solution better.

done

@aescolar aescolar merged commit 39e472f into zephyrproject-rtos:main May 28, 2024
22 checks passed
@ajarmouni-st ajarmouni-st deleted the fix_gpio_dt_flags_t branch May 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@ubieda ubieda ubieda approved these changes

@mnkp mnkp Awaiting requested review from mnkp

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

Assignees

@henrikbrixandersen henrikbrixandersen

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ajarmouni-st @henrikbrixandersen @mmahadevan108 @ubieda @galak @zephyrbot @aescolar