llext: xtensa: add support for the xt-clang toolchain #72940
Merged
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm,
stephanosio and
tejlmand
pillo79
previously approved these changes
May 17, 2024
teburd
previously approved these changes
May 17, 2024
tejlmand
requested changes
May 21, 2024
cmake/compiler/xt-clang/target.cmake
Outdated
| @@ -1,3 +1,7 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| include(${ZEPHYR_BASE}/cmake/compiler/xcc/target.cmake) | |||
|
|
|||
| if("${ARCH}" STREQUAL "xtensa") | |||
There was a problem hiding this comment.
xt-clang is clang for xtensa, so why this test and CMake file split, as all this CMake code is for the xtensa architecture ?
There was a problem hiding this comment.
@tejlmand could you re-check, please? I addressed your comment last Friday, 5 days ago.
To build LLEXT images using the xt-clang toolchain from Cadence linker flags have to be set similar to other toolchains. Add the missing cmake files. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
zephyrbot
requested review from
gchwier,
golowanow,
gopiotr,
hakehuang,
KamilxPaszkiet,
LukaszMrugala and
PerMac
tejlmand
approved these changes
May 29, 2024
teburd
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build LLEXT images using the xt-clang toolchain from Cadence linker flags have to be set similar to other toolchains. Add the missing cmake files.