chore(ci): new workflow target to handle ci execution from forks #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
May 14, 2024
otherwise lgtm 👍 |
what does the persist credential thing do ? |
it prevents adding the token to the git/config (see here) |
how is it not the default if they know it's completely broken O_o |
good question |
soonum
force-pushed
the
dt/ci/handle_forks
branch
from
a57d908
to
201b7de
Compare
|
I'm not a pro of the security stuff, so looks ok from afar, I let @aquint-zama give the final go ahead as for the credentials stuff, I guess all checkout instances could have the no persist for credentials but it could added in a further PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes zama-ai/tfhe-rs-internal#578