-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a SHA1 tutorial with modules #827
Conversation
3120708
to
7503dcf
Compare
@aPere3 @BourgerieQuentin : do you want to have a look to this notebook and .md? |
7503dcf
to
78decb2
Compare
55c1165
to
7a471f2
Compare
and maybe a pass by @yuxizama could be good |
Thx. Yes we'll have Yuxi make a review but let me first make your proposed changes. |
Will have a look this afternoon |
if I were you, I would wait a bit, since more changes are expected |
7a471f2
to
e5b1ce3
Compare
So I stop my experiments about no-module implementation, but they are in #851 |
So, first, I propose we let's have it reviewed and approved by @BourgerieQuentin and @aPere3 . Once done, I'll see with @yuxizama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @bcm-at-zama Thanks !
Let me fix mypy |
the CI looks green, or at least ruff and mypy. |
@yuxizama , we're ready now, content wise. Do you want to have a look now? Certainly we could also add a link from our https://docs.zama.ai/concrete/compilation/modules to this new tutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, I proposed some changes on the language.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing most of the comments by @yuxizama
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed two comments.
Besides that all good to me!
Let me squash that |
698902a
to
ceb7c9c
Compare
ceb7c9c
to
899a93b
Compare
Fine to merge that for me, @BourgerieQuentin |
Adding a SHA1 implementation, using Modules.
This .py will also be very useful to test Modules with non-v0 parameters.
closes https://github.com/zama-ai/concrete-internal/issues/711