Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend-python): update black dev dependency #798

Merged
merged 1 commit into from
May 22, 2024

Conversation

aquint-zama
Copy link
Contributor

No description provided.

Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, we can't merge like this. Also, why the change?

@aquint-zama
Copy link
Contributor Author

CI is failing, we can't merge like this. Also, why the change?

for security reason, black version used has 2 vulnerabilities:
https://github.com/zama-ai/concrete/security/dependabot/17
https://github.com/zama-ai/concrete/security/dependabot/16

@umut-sahin
Copy link
Contributor

I see, then let's fix the CI and merge 👍

@umut-sahin
Copy link
Contributor

CI seems to be broken still, with the same tests failing on each machine. It seems related to approximate, so maybe @rudy-6-4 have any ideas?

@BourgerieQuentin
Copy link
Member

Should be fixed by #812, let's finish the CI and merge then rebase PRs

@aquint-zama
Copy link
Contributor Author

\o/ CI is ok cc @umut-sahin

@aquint-zama aquint-zama merged commit 3740d38 into main May 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants