feat(frontend): warn if aes cpu flag isn't available #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
reviewed
Apr 2, 2024
| from cpuinfo import get_cpu_info | ||
|
|
||
| def _is_cpu_compatible() -> bool: | ||
| """Check if CPU can run Concrete |
There was a problem hiding this comment.
maybe
CPU has AES instruction
they can still run compilation ?
There was a problem hiding this comment.
Still not sure to check for aes only
rudy-6-4
reviewed
Apr 2, 2024
| bool: if the CPU does support required features to run Concrete | ||
| """ | ||
| flags = get_cpu_info()["flags"] | ||
| if "aes" in flags: |
rudy-6-4
reviewed
Apr 2, 2024
| return False | ||
|
|
||
| # Print a warning if the CPU can't run Concrete | ||
| if not _is_cpu_compatible(): |
There was a problem hiding this comment.
why at top level ?
can't they at least compile but not run ?
if the case, maybe the warning should be an error when calling a circuit execution.
and onluy a warning when calling compilation
There was a problem hiding this comment.
The idea is to show a warning whenever you import concrete. It take some time to run so I'm not sure about adding it as part of the execution call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.