fix(frontend-python): optimize extract bits #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
4 times, most recently
from
5fbb2d0
to
e2c333d
Compare
rudy-6-4
commented
Apr 3, 2024
frontends/concrete-python/tests/execution/test_bit_extraction.py
Outdated
Show resolved
Hide resolved
rudy-6-4
commented
Apr 3, 2024
umut-sahin
previously requested changes
Apr 3, 2024
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
3 times, most recently
from
3b49f34
to
b135255
Compare
umut-sahin
reviewed
Apr 4, 2024
BourgerieQuentin
approved these changes
Apr 4, 2024
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
4 times, most recently
from
863b485
to
45d85f0
Compare
BourgerieQuentin
approved these changes
Apr 11, 2024
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
from
45d85f0
to
116f0bb
Compare
umut-sahin
reviewed
Apr 16, 2024
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
2 times, most recently
from
c4c621a
to
b86c10d
Compare
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
4 times, most recently
from
44437b2
to
2e2a51a
Compare
rudy-6-4
dismissed
umut-sahin’s stale review
All changed has been made but reviewer not here
lsb and tlu calls were not minimized
rudy-6-4
force-pushed
the
fix/cp/bits-simplify
branch
from
2e2a51a
to
0d422b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsb and tlu calls were not minimized