Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency error setuptools #465

Closed
wants to merge 3 commits into from

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Jan 24, 2024

No description provided.

@jfrery jfrery requested a review from a team as a code owner January 24, 2024 15:15
@cla-bot cla-bot bot added the cla-signed label Jan 24, 2024
fd0r
fd0r previously approved these changes Jan 24, 2024
@fd0r
Copy link
Collaborator

fd0r commented Jan 24, 2024

We need to catch some warning in make determinism to make the CI pass

@RomanBredehoft
Copy link
Collaborator

@fd0r yes the warnings you are refering to are something we've already encountered more than a year ago : https://zama-ai.slack.com/archives/C0455QDGT6C/p1680683773533399?thread_ts=1680683767.733089&cid=C0455QDGT6C

based on what you've said, it seems its directly related to fixing https://github.com/zama-ai/concrete-ml-internal/issues/3407 and https://github.com/zama-ai/concrete-internal/issues/201

@RomanBredehoft
Copy link
Collaborator

although this comment https://stackoverflow.com/a/76044568/14802801 says that pypi fixed the issue by reverting setup tools to ... 65.6.3 🙂 (pypa/pip#11976)

@jfrery
Copy link
Collaborator Author

jfrery commented Jan 25, 2024

Thanks for the commit @fd0r and for the info @RomanBredehoft. I am having a look at the problem in this CI.

@jfrery
Copy link
Collaborator Author

jfrery commented May 22, 2024

Closing this as botocore is gone. I went a bit too fast. This is actually about the warning we get with make sync|setup_env. But is it still happening?

@jfrery jfrery closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants