Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(system,panzoom)!: return promise from transitioned panzoom ac… #3600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(system,panzoom)!: return promise from transitioned panzoom ac… #3600

wants to merge 2 commits into from

Conversation

bcakmakoglu
Copy link
Contributor

What's Changed?

  • Return a promise from panZoom actions that allow for transitions
    • Promise is resolved when the onEnd callback is triggered by the transition
  • Allows users to react to viewport transitions without arbitrary waiting times like setTimeout etc.

Notes

  • I'd think this would constitute a breaking change, wouldn't it? So this, if even desired, should probably go into v12? 😄

@bcakmakoglu bcakmakoglu changed the title refactor(system,panzoom): return promise from transitioned panzoom ac… refactor(system,panzoom)!: return promise from transitioned panzoom ac… Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bcakmakoglu